[pull] master from apache:master#135
Merged
Merged
Conversation
* Fix issue with groups not being reported in help output. AbstractHelpFormatter: * Swapped printHelp using Iterable<Option> with printHelp using Options. Effectively switching to using Options class to print the help. * Removed public String toSyntaxOptions(final Iterable<Option> options) as it was added in this version and should have only been used internally. HelpFormatterTest: * removed toSyntaxOptions using Iterable<Option> test. * added a printHelpTest with Iterable<Option> as previously we depended on printHelpTest with Option to test the code branch. * added verifyOptionGroupingOutput as a test to show that reported issue is corrected. * Don't break binary compatibility * Restore test Add test for toSyntaxOptions with iterable of options * fixed issues arising from reverting incompatible binary changes --------- Co-authored-by: Gary Gregory <garydgregory@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )