Skip to content

Mark the public class constants as @internal #471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
oliverklee opened this issue Feb 13, 2024 · 3 comments · Fixed by #472
Closed

Mark the public class constants as @internal #471

oliverklee opened this issue Feb 13, 2024 · 3 comments · Fixed by #472

Comments

@oliverklee
Copy link
Collaborator

Those class constants are not intended to be accessed from outside this package.

@sabberworm
Copy link
Collaborator

Do they need to be public at all?

@oliverklee
Copy link
Collaborator Author

Do they need to be public at all?

Some of them, yes, as they are either part of an interface (where only public consts are possible), or because they are accessed from another class.

@JakeQZ
Copy link
Collaborator

JakeQZ commented Feb 14, 2024

Do they need to be public at all?

Setting the visibility of class constants (e.g. with private const) has only been possible since PHP 7.1. So it's only now possible to clear this up since dropping the older PHP versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants