Skip to content

[TASK] Mark the public class constants as @internal #472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 15, 2024
Merged

[TASK] Mark the public class constants as @internal #472

merged 1 commit into from
Feb 15, 2024

Conversation

oliverklee
Copy link
Collaborator

Fixes #471

@oliverklee oliverklee self-assigned this Feb 13, 2024
JakeQZ
JakeQZ approved these changes Feb 15, 2024
View reviewed changes
Copy link
Collaborator

@JakeQZ JakeQZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They are used by other classes within the project, but not intended for third-party use, as they are subject to change or removal.

@JakeQZ JakeQZ merged commit 870c453 into main Feb 15, 2024
@JakeQZ JakeQZ deleted the task/internal-consts branch February 15, 2024 01:34
@JakeQZ JakeQZ mentioned this pull request Jan 25, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JakeQZ JakeQZ JakeQZ approved these changes

@sabberworm sabberworm Awaiting requested review from sabberworm

Assignees

@oliverklee oliverklee

Labels
None yet
Projects
None yet
Milestone
9.0.0: Drop support for PHP < 7.2 and...
Development

Successfully merging this pull request may close these issues.

Mark the public class constants as @internal
2 participants
@oliverklee @JakeQZ