Skip to content

Switch away from Hungarian notation #756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
47 tasks done
oliverklee opened this issue Nov 3, 2024 · 1 comment
Closed
47 tasks done

Switch away from Hungarian notation #756

oliverklee opened this issue Nov 3, 2024 · 1 comment
Assignees
Labels

Comments

@oliverklee
Copy link
Collaborator

oliverklee commented Nov 3, 2024

\$[a-z][A-Z]

  • ├── Comment
  • │   ├── Commentable.php [CLEANUP] Avoid Hungarian notion for the Commentable interface #804
  • │   └── Comment.php [TASK] Avoid Hungarian notation in a class #704
  • ├── CSSList
  • │   ├── AtRuleBlockList.php [CLEANUP] Avoid Hungarian notation in AtRuleBlockList #812
  • │   ├── CSSBlockList.php [TASK] Avoid Hungarian notation in CSSBlockList #817
  • │   ├── CSSList.php
  • │   ├── Document.php
  • │   └── KeyFrame.php
  • ├── OutputFormat.php
  • ├── OutputFormatter.php
  • ├── Parser.php
  • ├── Parsing
  • │   ├── Anchor.php
  • │   ├── OutputException.php
  • │   ├── ParserState.php
  • │   ├── SourceException.php
  • │   ├── UnexpectedEOFException.php
  • │   └── UnexpectedTokenException.php
  • ├── Property
  • │   ├── AtRule.php
  • │   ├── Charset.php
  • │   ├── CSSNamespace.php
  • │   ├── Import.php
  • │   ├── KeyframeSelector.php
  • │   └── Selector.php
  • ├── Renderable.php
  • ├── Rule
  • │   └── Rule.php
  • ├── RuleSet
  • │   ├── AtRuleSet.php
  • │   ├── DeclarationBlock.php
  • │   └── RuleSet.php
  • ├── Settings.php
  • └── Value
  • ├── CalcFunction.php
  • ├── CalcRuleValueList.php
  • ├── Color.php [CLEANUP] Avoid Hungarian notation in Color class #802
  • ├── CSSFunction.php
  • ├── CSSString.php
  • ├── LineName.php
  • ├── PrimitiveValue.php
  • ├── RuleValueList.php
  • ├── Size.php
  • ├── URL.php
  • ├── ValueList.php
  • └── Value.php
@oliverklee oliverklee self-assigned this Nov 3, 2024
oliverklee added a commit that referenced this issue Jan 25, 2025
Also change the implementing classes accordingly.

Part of #756.
oliverklee added a commit that referenced this issue Jan 25, 2025
oliverklee added a commit that referenced this issue Jan 25, 2025
Also adapt the implementing classes accordingly.

Part of #756.
JakeQZ pushed a commit that referenced this issue Jan 25, 2025
Also adapt the implementing classes accordingly.

Part of #756.
JakeQZ pushed a commit that referenced this issue Jan 26, 2025
oliverklee added a commit that referenced this issue Jan 26, 2025
oliverklee added a commit that referenced this issue Jan 26, 2025
JakeQZ pushed a commit that referenced this issue Jan 26, 2025
oliverklee added a commit that referenced this issue Jan 27, 2025
JakeQZ pushed a commit that referenced this issue Jan 27, 2025
oliverklee added a commit that referenced this issue Jan 27, 2025
JakeQZ pushed a commit that referenced this issue Jan 27, 2025
JakeQZ pushed a commit that referenced this issue Jan 27, 2025
oliverklee added a commit that referenced this issue Jan 28, 2025
JakeQZ pushed a commit that referenced this issue Jan 28, 2025
oliverklee added a commit that referenced this issue Jan 29, 2025
oliverklee added a commit that referenced this issue Mar 8, 2025
JakeQZ pushed a commit that referenced this issue Mar 8, 2025
JakeQZ pushed a commit that referenced this issue Mar 8, 2025
oliverklee added a commit that referenced this issue Mar 8, 2025
Also rename the getters to match the new property names.

Part of #756
oliverklee added a commit that referenced this issue Mar 8, 2025
JakeQZ pushed a commit that referenced this issue Mar 8, 2025
Also rename the getters to match the new property names.

Part of #756
JakeQZ pushed a commit that referenced this issue Mar 8, 2025
JakeQZ pushed a commit that referenced this issue Mar 8, 2025
oliverklee added a commit that referenced this issue Mar 8, 2025
Also rename the getters to match the new property names.

Part of #756
JakeQZ pushed a commit that referenced this issue Mar 8, 2025
JakeQZ pushed a commit that referenced this issue Mar 8, 2025
Also rename the getters to match the new property names.

Part of #756
oliverklee added a commit that referenced this issue Mar 9, 2025
Also rename the getters to match the new property names.

Part of #756
oliverklee added a commit that referenced this issue Mar 9, 2025
Also rename the getters to match the new property names.

Part of #756
oliverklee added a commit that referenced this issue Mar 9, 2025
Also make the parameter names non-Hungarian.

Part of #756
JakeQZ pushed a commit that referenced this issue Mar 9, 2025
Also rename the getters to match the new property names.

Part of #756
JakeQZ added a commit that referenced this issue Mar 9, 2025
Also make the parameter names non-Hungarian.

Part of #756

Co-authored-by: JakeQZ <jake.github@qzdesign.co.uk>
@oliverklee
Copy link
Collaborator Author

Finally, that's the last of them. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant