Skip to content

[CLEANUP] Avoid Hungarian notation in Color class #802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 24, 2025
Merged

[CLEANUP] Avoid Hungarian notation in Color class #802

merged 1 commit into from
Jan 24, 2025

Conversation

JakeQZ
Copy link
Collaborator

@JakeQZ JakeQZ commented Jan 24, 2025

Also rename some variables to be more descriptive and/or avoid abbreviations.

@JakeQZ
[CLEANUP] Avoid Hungarian notation in Color class
d3ca39d 
Also rename some variables to be more descriptive and/or avoid abbreviations.
@JakeQZ JakeQZ added the cleanup label Jan 24, 2025
@JakeQZ JakeQZ requested a review from oliverklee January 24, 2025 01:10
@JakeQZ JakeQZ self-assigned this Jan 24, 2025
@coveralls
Copy link

Coverage Status

coverage: 41.942%. remained the same
when pulling d3ca39d on cleanup/hungarian/color
into 9c70d85 on main.

oliverklee
oliverklee requested changes Jan 24, 2025
View reviewed changes
Copy link
Collaborator

@oliverklee oliverklee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹

@oliverklee oliverklee enabled auto-merge (squash) January 24, 2025 09:50
@oliverklee oliverklee merged commit 98c8bb8 into main Jan 24, 2025
21 checks passed
@oliverklee oliverklee deleted the cleanup/hungarian/color branch January 24, 2025 09:50
@oliverklee oliverklee mentioned this pull request Jan 25, 2025
Closed
47 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliverklee oliverklee oliverklee approved these changes

Assignees

@JakeQZ JakeQZ

Labels
cleanup
Projects
None yet
Milestone
9.0.0: Drop support for PHP < 7.2 and...
Development

Successfully merging this pull request may close these issues.
3 participants
@JakeQZ @coveralls @oliverklee