Skip to content

[TASK] Make Selector a Renderable #1017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 1, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ Please also have a look at our

### Changed

- Make `Selector` a `Renderable` (#1017)
- Mark `Selector::isValid()` as `@internal` (#1037)
- Mark parsing-related methods of most CSS elements as `@internal` (#908)
- Mark `OutputFormat::nextLevel()` as `@internal` (#901)
Expand Down
10 changes: 9 additions & 1 deletion src/Property/Selector.php
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,14 @@

namespace Sabberworm\CSS\Property;

use Sabberworm\CSS\OutputFormat;
use Sabberworm\CSS\Renderable;

/**
* Class representing a single CSS selector. Selectors have to be split by the comma prior to being passed into this
* class.
*/
class Selector
class Selector implements Renderable
{
/**
* regexp for specificity calculations
Expand Down Expand Up @@ -139,4 +142,9 @@ public function getSpecificity()
}
return $this->specificity;
}

public function render(OutputFormat $outputFormat): string
{
return $this->getSelector();
}
}
59 changes: 59 additions & 0 deletions tests/Functional/Property/SelectorTest.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,59 @@
<?php

declare(strict_types=1);

namespace Sabberworm\CSS\Tests\Functional\Selector;

use PHPUnit\Framework\TestCase;
use Sabberworm\CSS\OutputFormat;
use Sabberworm\CSS\Property\Selector;

/**
* @covers \Sabberworm\CSS\Property\Selector
*/
final class SelectorTest extends TestCase
{
/**
* @test
*/
public function renderWithVirginOutputFormatRendersSelectorPassedToConstructor(): void
{
$pattern = 'a';
$subject = new Selector($pattern);

self::assertSame($pattern, $subject->render(new OutputFormat()));
}

/**
* @test
*/
public function renderWithDefaultOutputFormatRendersSelectorPassedToConstructor(): void
{
$pattern = 'a';
$subject = new Selector($pattern);

self::assertSame($pattern, $subject->render(OutputFormat::create()));
}

/**
* @test
*/
public function renderWithCompactOutputFormatRendersSelectorPassedToConstructor(): void
{
$pattern = 'a';
$subject = new Selector($pattern);

self::assertSame($pattern, $subject->render(OutputFormat::createCompact()));
}

/**
* @test
*/
public function renderWithPrettyOutputFormatRendersSelectorPassedToConstructor(): void
{
$pattern = 'a';
$subject = new Selector($pattern);

self::assertSame($pattern, $subject->render(OutputFormat::createPretty()));
}
}
11 changes: 11 additions & 0 deletions tests/Unit/Property/SelectorTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -6,12 +6,23 @@

use PHPUnit\Framework\TestCase;
use Sabberworm\CSS\Property\Selector;
use Sabberworm\CSS\Renderable;

/**
* @covers \Sabberworm\CSS\Property\Selector
*/
final class SelectorTest extends TestCase
{
/**
* @test
*/
public function implementsRenderable(): void
{
$subject = new Selector('a');

self::assertInstanceOf(Renderable::class, $subject);
}

/**
* @test
*/
Expand Down