Skip to content

[TASK] Make Selector a Renderable #1017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 1, 2025
Merged

[TASK] Make Selector a Renderable #1017

merged 1 commit into from
Mar 1, 2025

Conversation

oliverklee
Copy link
Collaborator

This is required to be able to drop __toString for this class.

@oliverklee oliverklee self-assigned this Feb 27, 2025
@oliverklee oliverklee marked this pull request as draft February 27, 2025 11:07
@oliverklee oliverklee force-pushed the feature/selector-renderable branch from e94f8d4 to 70bd391 Compare February 27, 2025 11:07
@coveralls
Copy link

coveralls commented Feb 27, 2025 •
edited
Loading

Coverage Status

coverage: 55.799% (+0.05%) from 55.753%
when pulling 31abb69 on feature/selector-renderable
into 7ef82db on main.

@oliverklee oliverklee force-pushed the feature/selector-renderable branch 5 times, most recently from 0115346 to 323921f Compare February 28, 2025 19:57
@oliverklee
[TASK] Make Selector a Renderable
31abb69 
This is required to be able to drop `__toString` for this class.
@oliverklee oliverklee force-pushed the feature/selector-renderable branch from 323921f to 31abb69 Compare March 1, 2025 09:32
@oliverklee oliverklee marked this pull request as ready for review March 1, 2025 09:33
@oliverklee oliverklee requested a review from JakeQZ March 1, 2025 09:33
JakeQZ
JakeQZ approved these changes Mar 1, 2025
View reviewed changes
Copy link
Collaborator

@JakeQZ JakeQZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see - ``DeclarationBlock::render()` does an implicit cast to string for the selectors.

I'm beginning to accept that $pattern can work as a variable name to for a selector string to distinguish it from a Selector object.

@JakeQZ JakeQZ merged commit b6d0b70 into main Mar 1, 2025
21 checks passed
@JakeQZ JakeQZ deleted the feature/selector-renderable branch March 1, 2025 10:33
oliverklee added a commit that referenced this pull request Mar 29, 2025
@oliverklee
[TASK] Add to UML diagram that Selector implements Renderable
4c8af80 
Followup to #1017
@oliverklee oliverklee mentioned this pull request Mar 29, 2025
Merged
JakeQZ pushed a commit that referenced this pull request Mar 29, 2025
@oliverklee
[TASK] Add to UML diagram that Selector implements Renderable (#1224
8ea11a4 
)

Followup to #1017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JakeQZ JakeQZ JakeQZ approved these changes

Assignees

@oliverklee oliverklee

Labels
cleanup enhancement
Projects
None yet
Milestone
9.0.0: Drop support for PHP < 7.2 and...
Development

Successfully merging this pull request may close these issues.
3 participants
@oliverklee @coveralls @JakeQZ