Skip to content

[CLEANUP] Avoid Hungarian notation for *stack* #1064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 4, 2025
Merged

Conversation

oliverklee
Copy link
Collaborator

Part of #756

@coveralls
Copy link

Coverage Status

coverage: 55.726%. remained the same
when pulling b283aab on cleanup/hungarian/stack
into f54a5b6 on main.

Copy link
Collaborator

@JakeQZ JakeQZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the commit message use `stack`?

@oliverklee
Copy link
Collaborator Author

Should the commit message use stack?

I'm not sure I understand what you mean. Are you proposing to drop the asterisks? Or something else?

@oliverklee
Copy link
Collaborator Author

Or did I make a typo?

@JakeQZ
Copy link
Collaborator

JakeQZ commented Mar 4, 2025

Should the commit message use `stack`?

I'm not sure I understand what you mean. Are you proposing to drop the asterisks? Or something else?

I just wondered why you used asterisks rather than backticks.

@oliverklee
Copy link
Collaborator Author

I just wondered why you used asterisks rather than backticks.

Ah, thanks! Now I understand!

I used the asterisks (in addition to the backticks) to signify that I also changed variable names that ended in or started with stack. 🙂

If you find this confusing, I'd be perfectly fine with removing the asterisks from the commit message.

@JakeQZ
Copy link
Collaborator

JakeQZ commented Mar 4, 2025

I just wondered why you used asterisks rather than backticks.

Ah, thanks! Now I understand!

I used the asterisks (in addition to the backticks) to signify that I also changed variable names that ended in or started with stack. 🙂

If you find this confusing, I'd be perfectly fine with removing the asterisks from the commit message.

I see now. Also, I hadn't realized there were backticks as well.

@JakeQZ JakeQZ merged commit c19a955 into main Mar 4, 2025
21 checks passed
@JakeQZ JakeQZ deleted the cleanup/hungarian/stack branch March 4, 2025 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants