Skip to content

[CLEANUP] Avoid Hungarian notation for size #1085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 5, 2025
Merged

Conversation

oliverklee
Copy link
Collaborator

Part of #756

@coveralls
Copy link

Coverage Status

coverage: 55.726%. remained the same
when pulling 6a5d8be on cleanup/hungarian/size
into 2c3fe72 on main.

Copy link
Collaborator

@JakeQZ JakeQZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we're renaming this, we can change it to $number to match its official name:

@oliverklee
Copy link
Collaborator Author

As we're renaming this, we can change it to $number to match its official name:

I'm all for this. However, I'd prefer to do this in a separate change as this involves renaming the setter/getter (if we want to do it properly), which I'd prefer not to do as a drive-by change of a no-changelog-entry cleanup. I've created #1087 for this.

Copy link
Collaborator

@JakeQZ JakeQZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we're renaming this, we can change it to $number to match its official name:

I'm all for this. However, I'd prefer to do this in a separate change as this involves renaming the setter/getter (if we want to do it properly), which I'd prefer not to do as a drive-by change of a no-changelog-entry cleanup. I've created #1087 for this.

We can't so easily rename the getter and setter since they are public methods. To do so (seamlessly) would mean adding the newly named methods and having the old methods chain onto the new ones while the old ones are deprecated.

@JakeQZ JakeQZ merged commit 1ffafd9 into main Mar 5, 2025
21 checks passed
@JakeQZ JakeQZ deleted the cleanup/hungarian/size branch March 5, 2025 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants