Skip to content

[BUGFIX] Fix the return type of Selector::isValid() #1174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JakeQZ merged 2 commits into from
Mar 16, 2025
Merged

[BUGFIX] Fix the return type of Selector::isValid() #1174

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
db81d31
[BUGFIX] Fix the return type of `Selector::isValid()`
oliverklee Mar 16, 2025
3104219
Make it static again
oliverklee Mar 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Make it static again
  • Loading branch information
@oliverklee
oliverklee committed Mar 16, 2025
commit 31042196dccfd1694f6a9515dd8b540a7128cbcd
3 changes: 2 additions & 1 deletion src/Property/Selector.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,8 @@ class Selector implements Renderable
*/
public static function isValid(string $selector): bool
{
$numberOfMatches = \preg_match(self::SELECTOR_VALIDATION_RX, $selector);
// Note: We need to use `static::` here as the constant is overridden in the `KeyframeSelector` class.
$numberOfMatches = \preg_match(static::SELECTOR_VALIDATION_RX, $selector);

return $numberOfMatches === 1;
}
Expand Down