[BUGFIX] Fix the return type of Selector::isValid()
#1174
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JakeQZ
approved these changes
Mar 16, 2025
JakeQZ
requested changes
Mar 16, 2025
src/Property/Selector.php
Outdated
| { | ||
| return \preg_match(static::SELECTOR_VALIDATION_RX, $selector); | ||
| $numberOfMatches = \preg_match(self::SELECTOR_VALIDATION_RX, $selector); |
There was a problem hiding this comment.
This needs to be static because KeyframeSelector overrides the SELECTOR_VALIDATION_RX constant to also allow keyframe animation percentage.
There was a problem hiding this comment.
Ah, that's why. Fix coming up …
4f80f1e to
3104219
Compare
JakeQZ
approved these changes
Mar 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1043
Part of #811