[BUGFIX] Ensure column number set after RuleSet::addRule()
#1263
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliverklee
approved these changes
May 27, 2025
JakeQZ
added a commit
that referenced
this pull request
Jun 4, 2025
This is the backport of #1263, #1262 and #1265. Since `getLineNo()` and `getColNo()`, which always returned an `int`, are deprecated, using their replacements, which may return `null`, for `Rule`s in a `RuleSet` may cause issues. The fixes ensure that such `Rule`s will always have a valid position, so the new methods will not return `null` in that situation, and a straightforward replacement can be done. Part of #974.
JakeQZ
added a commit
that referenced
this pull request
Jun 4, 2025
This is the backport of #1263, #1262 and #1265. Since `getLineNo()` and `getColNo()`, which always returned an `int`, are deprecated, using their replacements, which may return `null`, for `Rule`s in a `RuleSet` may cause issues. The fixes ensure that such `Rule`s will always have a valid position, so the new methods will not return `null` in that situation, and a straightforward replacement can be done. Part of #974.
JakeQZ
added a commit
that referenced
this pull request
Jun 4, 2025
This is the backport of #1263, #1262 and #1265. Since `getLineNo()` and `getColNo()`, which always returned an `int`, are deprecated, using their replacements, which may return `null`, for `Rule`s in a `RuleSet` may cause issues. The fixes ensure that such `Rule`s will always have a valid position, so the new methods will not return `null` in that situation, and a straightforward replacement can be done. Part of #974.
oliverklee
pushed a commit
that referenced
this pull request
Jun 4, 2025
This is the backport of #1263, #1262 and #1265. Since `getLineNo()` and `getColNo()`, which always returned an `int`, are deprecated, using their replacements, which may return `null`, for `Rule`s in a `RuleSet` may cause issues. The fixes ensure that such `Rule`s will always have a valid position, so the new methods will not return `null` in that situation, and a straightforward replacement can be done. Part of #974.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that this bug (or inconsistency) only occurs following the addtion of
getColumnNumber()returning a nullableint(#1221 and #1225). These changes are not yet included in any release.Part of #974.