[BUGFIX] Ensure valid position after AddRule
#1271
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the backport of #1263, #1262 and #1265.
Since
getLineNo()
andgetColNo()
, which always returned anint
, are deprecated, using their replacements, which may returnnull
, forRule
s in aRuleSet
may cause issues.The fixes ensure that such
Rule
s will always have a valid position, so the new methods will not returnnull
in that situation, and a straightforward replacement can be done.Part of #974.