Skip to content

[FEATURE] Add support for the dvh, lvh and svh length units #415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
oliverklee merged 6 commits into from
Feb 17, 2024
Merged

[FEATURE] Add support for the dvh, lvh and svh length units #415

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
16b5f18
Add support for dvh, svh, lvh. Close #412
KaiOnGitHub Aug 1, 2023
bc058a4
fix 120 char per line limit
KaiOnGitHub Aug 2, 2023
2a192bc
Merge branch 'main' into patch-1
sabberworm Feb 16, 2024
2d1b071
Add `TestCase` and changelog entry
JakeQZ Feb 17, 2024
7e6ffdf
Add `void` return type hint for `parsesUnit`.
JakeQZ Feb 17, 2024
04b92ea
Reword CHANGELOG entry.
JakeQZ Feb 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add void return type hint for parsesUnit. 
Co-authored-by: Oliver Klee <github@oliverklee.de>
  • Loading branch information
@JakeQZ @oliverklee
JakeQZ and oliverklee authored Feb 17, 2024
commit 7e6ffdfdb37d48f30506132951979656bc041317
2 changes: 1 addition & 1 deletion tests/Value/SizeTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ function (string $unit): array {
*
* @dataProvider provideUnit
*/
public function parsesUnit(string $unit)
public function parsesUnit(string $unit): void
{
$subject = Size::parse(new ParserState('1' . $unit, Settings::create()));

Expand Down