-
Notifications
You must be signed in to change notification settings - Fork 144
[FEATURE] Add support for the dvh
, lvh
and svh
length units
#415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
16b5f18
Add support for dvh, svh, lvh. Close #412
KaiOnGitHub bc058a4
fix 120 char per line limit
KaiOnGitHub 2a192bc
Merge branch 'main' into patch-1
sabberworm 2d1b071
Add `TestCase` and changelog entry
JakeQZ 7e6ffdf
Add `void` return type hint for `parsesUnit`.
JakeQZ 04b92ea
Reword CHANGELOG entry.
JakeQZ File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,51 @@ | ||
<?php | ||
|
||
namespace Sabberworm\CSS\Tests\Value; | ||
|
||
use PHPUnit\Framework\TestCase; | ||
use Sabberworm\CSS\Parsing\ParserState; | ||
use Sabberworm\CSS\Settings; | ||
use Sabberworm\CSS\Value\Size; | ||
|
||
/** | ||
* @covers \Sabberworm\CSS\Value\Size | ||
*/ | ||
final class SizeTest extends TestCase | ||
{ | ||
/** | ||
* @return array<string, array{0: string}> | ||
*/ | ||
public static function provideUnit(): array | ||
{ | ||
$units = [ | ||
'px', 'pt', 'pc', | ||
'cm', 'mm', 'mozmm', 'in', | ||
'vh', 'dvh', 'svh', 'lvh', | ||
'vw', 'vmin', 'vmax', 'rem', | ||
'%', 'em', 'ex', 'ch', 'fr', | ||
'deg', 'grad', 'rad', 's', 'ms', 'turn', 'Hz', 'kHz', | ||
]; | ||
|
||
return \array_combine( | ||
$units, | ||
\array_map( | ||
function (string $unit): array { | ||
return [$unit]; | ||
}, | ||
$units | ||
) | ||
); | ||
} | ||
|
||
/** | ||
* @test | ||
* | ||
* @dataProvider provideUnit | ||
*/ | ||
public function parsesUnit(string $unit): void | ||
{ | ||
$subject = Size::parse(new ParserState('1' . $unit, Settings::create())); | ||
|
||
self::assertSame($unit, $subject->getUnit()); | ||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.