-
Notifications
You must be signed in to change notification settings - Fork 144
[TASK] Deprecate DeclarationBlock::expandShorthands
#558
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TASK] Deprecate DeclarationBlock::expandShorthands
#558
Conversation
The `expandShorthands`/`createShorthands` Functions are deprecated and will be removed without substitution in version 10.0. Expanding and creating the shorthand notation is out of the scope of this library. If you want to include this functionality in your project or build it into a separate package, get the code from the v8.5.1 version of this library. Signed-off-by: Daniel Ziegenberg <daniel@ziegenberg.at>
00a8754
to
814d923
Compare
Signed-off-by: Daniel Ziegenberg <daniel@ziegenberg.at>
I removed the now superfluous tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's deprecate it (with a corresponding changelog entry), but keep the functionality intact.
In the commit message and PR title, this should be a [TASK]
, not a mere (code) [CLEANUP]
.
DeclarationBlock::expandShorthands
DeclarationBlock::expandShorthands
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
The
expandShorthands
/createShorthands
Functions are deprecated and will be removed without substitution in version 10.0. Expanding and creating the shorthand notation is out of the scope of this library. If you want to include this functionality in your project or build it into a separate package, get the code from the v8.5.1 version of this library.Helps with fixing #512