Skip to content

[TASK] Deprecate DeclarationBlock::expandShorthands #558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ziegenberg
Copy link
Contributor

@ziegenberg ziegenberg commented Jun 18, 2024

The expandShorthands/createShorthands Functions are deprecated and will be removed without substitution in version 10.0. Expanding and creating the shorthand notation is out of the scope of this library. If you want to include this functionality in your project or build it into a separate package, get the code from the v8.5.1 version of this library.

Helps with fixing #512

The `expandShorthands`/`createShorthands` Functions are deprecated and
will be removed without substitution in version 10.0.  Expanding and
creating the shorthand notation is out of the scope of this library. If
you want to include this functionality in your project or build it into
a separate package, get the code from the v8.5.1 version of this
library.

Signed-off-by: Daniel Ziegenberg <daniel@ziegenberg.at>
@ziegenberg ziegenberg force-pushed the deprecate-shorthand-functions_1 branch from 00a8754 to 814d923 Compare June 18, 2024 09:19
Signed-off-by: Daniel Ziegenberg <daniel@ziegenberg.at>
@ziegenberg
Copy link
Contributor Author

I removed the now superfluous tests.

Copy link
Collaborator

@oliverklee oliverklee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's deprecate it (with a corresponding changelog entry), but keep the functionality intact.

In the commit message and PR title, this should be a [TASK], not a mere (code) [CLEANUP].

@oliverklee oliverklee changed the title [CLEANUP] Deprecate DeclarationBlock::expandShorthands [TASK] Deprecate DeclarationBlock::expandShorthands Jun 18, 2024
Copy link
Collaborator

@oliverklee oliverklee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@oliverklee oliverklee merged commit b979dc8 into MyIntervals:main Jun 18, 2024
18 checks passed
@ziegenberg ziegenberg deleted the deprecate-shorthand-functions_1 branch June 18, 2024 22:42
oliverklee added a commit that referenced this pull request Sep 10, 2024
This is the backport of #714 and the tickets leading up to that:
- #578
- #580
- #579
- #577
- #576
- #575
- #574
- #573
- #572
- #571
- #570
- #569
- #566
- #567
- #558
oliverklee added a commit that referenced this pull request Sep 10, 2024
This is the backport of #714 and all those changes:

- #578
- #580
- #579
- #577
- #576
- #575
- #574
- #573
- #572
- #571
- #570
- #569
- #566
- #567
- #558
JakeQZ pushed a commit that referenced this pull request Sep 10, 2024
This is the backport of #714 and all those changes:

- #578
- #580
- #579
- #577
- #576
- #575
- #574
- #573
- #572
- #571
- #570
- #569
- #566
- #567
- #558
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants