Skip to content

[TASK] Remove DeclarationBlock::setSelector #560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

ziegenberg
Copy link
Contributor

Removing one function after another.

Signed-off-by: Daniel Ziegenberg <daniel@ziegenberg.at>
@oliverklee oliverklee changed the title [CLEANUP] Final removal of DeclarationBlock::setSelector [TASK] Remove DeclarationBlock::setSelector Jun 18, 2024
@ziegenberg ziegenberg requested a review from oliverklee June 18, 2024 15:02
@ziegenberg
Copy link
Contributor Author

I'm not going to fix the commit message, as that would require a force-push to have any effect, and that would contradict the desired fix-up commit. But I will remember the commit message format for future PRs.

Copy link
Collaborator

@oliverklee oliverklee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🙏

@oliverklee oliverklee merged commit 0ff08fa into MyIntervals:main Jun 18, 2024
18 checks passed
@ziegenberg ziegenberg deleted the remove-deprecated-declarationblock-setselector branch June 18, 2024 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants