Skip to content

[TASK] Remove DeclarationBlock::setSelector #560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 18, 2024
Merged

[TASK] Remove DeclarationBlock::setSelector #560

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7b05ac7
[CLEANUP] Final removal of DeclarationBlock::setSelector
ziegenberg Jun 18, 2024
ea68788
fixup! [CLEANUP] Final removal of DeclarationBlock::setSelector
ziegenberg Jun 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ This project adheres to [Semantic Versioning](https://semver.org/).

### Removed

- Remove `DeclarationBlock::setSelector()` (#560)
- Drop support for PHP < 7.2 (#420)

### Fixed
Expand Down
12 changes: 0 additions & 12 deletions src/RuleSet/DeclarationBlock.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,18 +156,6 @@ public function getSelector()
return $this->getSelectors();
}

/**
* @param Selector|string $mSelector
* @param CSSList|null $oList
*
* @return void
*
* @deprecated will be removed in version 9.0; use `setSelectors()` instead
*/
public function setSelector($mSelector, $oList = null)
{
$this->setSelectors($mSelector, $oList);
}

/**
* @return array<int, Selector|string>
Expand Down