[BUGFIX] Support Lint on Windows #610
Conversation
|
I don't understand the errors. This is exaclty the same as we have in Emogrifier, and it works fine locally. Are the GitHub actions missing a |
Apparently so. |
.github/workflows/ci.yml
Outdated
| @@ -30,6 +30,9 @@ jobs: | |||
| tools: composer:v2 | |||
| coverage: none | |||
|
|
|||
| - name: Composer Update | |||
| run: composer update | |||
There was a problem hiding this comment.
We'll also need the caching (and, to keep things consistent to ease maintenance for us, move the PHP version into a matrix). I'll create a pre-patch for this.
composer.json
Outdated
| @@ -70,7 +71,7 @@ | |||
| "@ci:tests" | |||
| ], | |||
| "ci:php:fixer": "\"./.phive/php-cs-fixer\" --config=config/php-cs-fixer.php fix --dry-run -v --show-progress=dots --diff bin src tests config", | |||
| "ci:php:lint": "find src tests config bin -name '*.php' -print0 | xargs -0 -n 1 -P 4 php -l", | |||
| "ci:php:lint": "\"./vendor/bin/parallel-lint\" src tests config bin", | |||
There was a problem hiding this comment.
| "ci:php:lint": "\"./vendor/bin/parallel-lint\" src tests config bin", | |
| "ci:php:lint": "parallel-lint src tests config bin", |
There was a problem hiding this comment.
This works for me. I think it used not to. I just copied what was in Emogrifier. I guess Composer has been updated not to require a specific path to the bin directory.
This is a pre-patch before we can switch the PHP linting to the parallel lint package in #610.
This is a pre-patch before we can switch the PHP linting to the parallel lint package in #610.
Use `php-parallel-lint` package to avoid *nix-specific command. Fixes #598.
|
Had to use |
Use
php-parallel-lintpackage to avoid *nix-specific command.Fixes #598.