Skip to content

[TASK] Install Composer dependencies for PHP lint CI job #611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 22, 2024
Merged

[TASK] Install Composer dependencies for PHP lint CI job #611

merged 1 commit into from
Jun 22, 2024

Conversation

oliverklee
Copy link
Collaborator

This is a pre-patch before we can switch the PHP linting to the parallel lint package in #610.

@oliverklee
[TASK] Install Composer dependencies for PHP lint CI job
026ddbd 
This is a pre-patch before we can switch the PHP linting to
the parallel lint package in #610.
@oliverklee oliverklee requested review from sabberworm and JakeQZ June 22, 2024 07:26
@oliverklee oliverklee self-assigned this Jun 22, 2024
JakeQZ
JakeQZ approved these changes Jun 22, 2024
View reviewed changes
Copy link
Collaborator

@JakeQZ JakeQZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine. It duplicates chunks from all the other sections.

Is there any way of avoiding such duplication in GitHub actions - like calling some common function to do the set-up?

@JakeQZ JakeQZ merged commit ab47c9d into main Jun 22, 2024
18 checks passed
@JakeQZ JakeQZ deleted the task/composer-for-lint branch June 22, 2024 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JakeQZ JakeQZ JakeQZ approved these changes

@sabberworm sabberworm Awaiting requested review from sabberworm

Assignees

@oliverklee oliverklee

Labels
None yet
Projects
None yet
Milestone
9.0.0: Drop support for PHP < 7.2 and...
Development

Successfully merging this pull request may close these issues.
2 participants
@oliverklee @JakeQZ