-
Notifications
You must be signed in to change notification settings - Fork 144
[TASK] Mark OutputFormatter
as @internal
#896
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
79d9544
to
ec45f29
Compare
20bb6df
to
f20a6af
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think so.
@sabberworm, would you agree?
Actually maybe not. See #895 (comment). It might not be used from the outside, but may need to be constructed and passed around, depending on how we resolve the circular dependency. |
f20a6af
to
1696d58
Compare
I've proposed a path forward in #907. |
370dee5
to
8c36d23
Compare
@sabberworm ping |
8c36d23
to
0a17c5c
Compare
Marking as draft pending #907, |
075e5d3
to
c7b73db
Compare
542332d
to
e3bf18c
Compare
efa0105
to
fe78fb7
Compare
fe78fb7
to
7eb5934
Compare
Ping @JakeQZ @sabberworm - I'd like to get this merged soon-ish so I can reduce the number of open PRs created by me (which reduces the amount of rebasing I need to do). |
This class should only be used for formatting CSS from within this library. It is not intended to be called from outside.
7eb5934
to
900883c
Compare
Yes, I think currently users of this library provide an Also, this is consistent with the proposed change in #898. So 👍 from me now. |
This is the V8.x backport of #896.
This is the V8.x backport of #896.
This class should only be used for formatting CSS from within this library. It is not intended to be called from outside.