[CLEANUP] Use the accessor for the charset in ParserState
#937
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also make the getter `private` as it's not (intended to be) called from the outside. As the whole `ParserState` class is `@internal`, this does does not require a deprecation process.
dfd1fb8 to
c5f8226
Compare
JakeQZ
reviewed
Feb 16, 2025
There was a problem hiding this comment.
It isn't usual to use an accessor method for a class property within the class itself. The accessor methods are typically provided for use by other classes (and may be marked as internal if only intended for intra-library use). So this doesn't seem right to me.
|
Okay, closing in favor of #941 then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also make the getter
privateas it's not (intended to be) called from the outside.As the whole
ParserStateclass is@internal, this does does not require a deprecation process.