Skip to content

[TASK] Drop the unused ParserState::getCharset() #941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 16, 2025
Merged

[TASK] Drop the unused ParserState::getCharset() #941

merged 1 commit into from
Feb 16, 2025

Conversation

oliverklee
Copy link
Collaborator

As this class is @internal, we do not need a deprecation process for this.

@oliverklee oliverklee requested a review from JakeQZ February 16, 2025 11:00
@oliverklee oliverklee self-assigned this Feb 16, 2025
@oliverklee oliverklee mentioned this pull request Feb 16, 2025
Closed
@coveralls
Copy link

coveralls commented Feb 16, 2025 •
edited
Loading

Coverage Status

coverage: 50.801% (+0.05%) from 50.747%
when pulling 8e013bf on task/drop-unused-getcharset
into 0094c4f on main.

@oliverklee
[TASK] Drop the unused ParserState::getCharset()
8e013bf 
As this class is `@internal`, we do not need a deprecation
process for this.
@oliverklee oliverklee force-pushed the task/drop-unused-getcharset branch from 0ffd83a to 8e013bf Compare February 16, 2025 11:29
@JakeQZ JakeQZ merged commit 631c07e into main Feb 16, 2025
21 checks passed
@JakeQZ JakeQZ deleted the task/drop-unused-getcharset branch February 16, 2025 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JakeQZ JakeQZ JakeQZ approved these changes

Assignees

@oliverklee oliverklee

Labels
None yet
Projects
None yet
Milestone
9.0.0: Drop support for PHP < 7.2 and...
Development

Successfully merging this pull request may close these issues.
3 participants
@oliverklee @coveralls @JakeQZ