Skip to content

PHPCS now requires PHP 7.2.0+ #972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 14, 2025
Merged

Conversation

jrfnl
Copy link
Member

@jrfnl jrfnl commented Apr 14, 2025

Description

Suggested changelog entry

The minimum required PHP version has changed from 5.4.0 to 7.2.0.

Base automatically changed from phpcs-4.0/feature/ghactions-enable-ci to 4.x April 14, 2025 11:52
Co-authored-by: jrfnl <jrfnl@users.noreply.github.com>
@jrfnl jrfnl marked this pull request as ready for review April 14, 2025 11:53
@jrfnl jrfnl force-pushed the phpcs-4.0/feature/drop-support-php-lt-7.2 branch from 8de604b to a7a27b9 Compare April 14, 2025 11:53
@jrfnl
Copy link
Member Author

jrfnl commented Apr 14, 2025

The fact that coverage has dropped a lot is as expected. This will go up again once the code related to support of PHP < 7.2 is being removed as well (separate PR, upcoming).

@jrfnl jrfnl merged commit 0820ccb into 4.x Apr 14, 2025
59 of 60 checks passed
@jrfnl jrfnl deleted the phpcs-4.0/feature/drop-support-php-lt-7.2 branch April 14, 2025 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants