Drop support for PHP < 7.2 - step 2 (drop polyfills and work-arounds) #973
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Includes removing some related tests which have now become redundant. Co-authored-by: jrfnl <jrfnl@users.noreply.github.com>
The ASP and script style open tags are only recognized as `T_OPEN_TAG`/`T_OPEN_TAG_WITH_ECHO` in PHP < 7.0. This means that the sniff can now be simplified to only look for `T_INLINE_HTML` and that the tests related to PHP < 7.0 can also be removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Tokenizer: remove backfill code for PHP < 7.2
Includes removing some related tests which have now become redundant.
MessageCollector: remove polyfill for PHP < 7.2
Generic/DisallowAlternativePHPTags: remove support for PHP < 7.2
The ASP and script style open tags are only recognized as
T_OPEN_TAG/T_OPEN_TAG_WITH_ECHOin PHP < 7.0.This means that the sniff can now be simplified to only look for
T_INLINE_HTMLand that the tests related to PHP < 7.0 can also be removed.Tests: remove some PHP < 7.2 specific code
Suggested changelog entry
N/A
Related issues/external references
Related to #972