[cap/mount_options] Fix "mount_name" compatibility with Vagrant 2.2.15+#386
Merged
[cap/mount_options] Fix "mount_name" compatibility with Vagrant 2.2.15+#386
Conversation
This was referenced Apr 14, 2021
7f0df0d to
a7cffc2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #384
Vagrant 2.2.15 includes hashicorp/vagrant#12184 which apparently changes the expected interface of
mount_namesynced folder capability. It seems that Vagrant maintainers didn't consider that there could be other plugins implementing this capability on their side :(As the result, in order to keep the backward compatibility with older versions of Vagrant we have to do a dirty hack with
mount_nameimplementation, assuming that it could be called with 2 or 3 positional arguments.