Skip to content

Commit 33398fa

Browse files
committed
Draggable: Skip window bubbling test in IE 8
IE 8 implements DOM Level 2 Events which only has events propagate up to the document, not the window. Ref #10818 Ref jquerygh-1621 Closes jquerygh-1627
1 parent 81a0029 commit 33398fa

File tree

1 file changed

+20
-14
lines changed

1 file changed

+20
-14
lines changed

tests/unit/draggable/core.js

Lines changed: 20 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -345,21 +345,27 @@ test( "ui-draggable-handle managed correctly in nested draggables", function( as
345345
assert.hasClasses( child, "ui-draggable-handle", "child retains class name on destroy" );
346346
} );
347347

348-
test( "does not stop propagation to window", function( assert ) {
349-
expect( 1 );
350-
var element = $( "#draggable1" ).draggable();
351-
352-
var handler = function() {
353-
assert.ok( true, "mouseup propagates to window" );
354-
};
355-
$( window ).on( "mouseup", handler );
348+
// Support: IE 8 only
349+
// IE 8 implements DOM Level 2 Events which only has events bubble up to the document.
350+
// We skip this test since it would be impossible for it to pass in such an environment.
351+
QUnit[ document.documentMode === 8 ? "skip" : "test" ](
352+
"does not stop propagation to window",
353+
function( assert ) {
354+
expect( 1 );
355+
var element = $( "#draggable1" ).draggable();
356+
357+
var handler = function() {
358+
assert.ok( true, "mouseup propagates to window" );
359+
};
360+
$( window ).on( "mouseup", handler );
356361

357-
element.simulate( "drag", {
358-
dx: 10,
359-
dy: 10
360-
} );
362+
element.simulate( "drag", {
363+
dx: 10,
364+
dy: 10
365+
} );
361366

362-
$( window ).off( "mouseup", handler );
363-
} );
367+
$( window ).off( "mouseup", handler );
368+
}
369+
);
364370

365371
} );

0 commit comments

Comments
 (0)