Draggable: Skip window bubbling test in IE 8 #1627
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IE 8 implements DOM Level 2 Events which only has events propagate up to the document, not the window. Ref #10818 Ref jquerygh-1621
| // IE 8 implements DOM Level 2 Events which only has events bubble up to the document. | ||
| // We skip this test since it would be impossible for it to pass in such an environment. | ||
| if ( document.documentMode !== 8 ) { | ||
| test( "does not stop propagation to window", function( assert ) { |
There was a problem hiding this comment.
Could use QUnit.skip here, something like:
QUnit[ document.documentMode === 8 ? "skip" : "test" ]( "does not stop propagation to window", function( assert ) {Otherwise fine to land as-is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IE 8 implements DOM Level 2 Events which only has events propagate
up to the document, not the window.
Ref #10818
Ref gh-1621