Skip to content

Mouse: Don't stop propagation of mouseup #1621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jzaefferer merged 1 commit into from
Oct 18, 2015
Merged

Mouse: Don't stop propagation of mouseup #1621

jzaefferer merged 1 commit into from
Oct 18, 2015

Conversation

@hmethvin
Copy link
Contributor

@hmethvin hmethvin commented Oct 18, 2015

Fixes #10818

@jquerybot
Copy link

jquerybot commented Oct 18, 2015

Thank you for your pull request. It looks like this may be your first contribution to a jQuery Foundation project, if so we need you to sign our Contributor License Agreement (CLA).

📝 Please visit http://contribute.jquery.org/CLA/ to sign.

After you signed, the PR is checked again automatically after a minute. If there's still an issue, please reply here to let us know.

If you've already signed our CLA, it's possible your git author information doesn't match your CLA signature (both your name and email have to match), for more information, check the status of your CLA check.

@jzaefferer
Copy link
Member

jzaefferer commented Oct 18, 2015

Looks good to me!

@jzaefferer jzaefferer merged commit a1d6920 into jquery:master Oct 18, 2015
@jzaefferer
Copy link
Member

jzaefferer commented Oct 18, 2015

Thank you!

@hmethvin hmethvin deleted the mouse-mouseup branch October 18, 2015 18:28
@jzaefferer
Copy link
Member

jzaefferer commented Oct 25, 2015

The new test is failing on IE8: http://swarm.jquery.org/result/740908 "Expected 1 assertions, but 0 were run"

@scottgonzalez
Copy link
Member

scottgonzalez commented Oct 26, 2015

Heh. Welcome to 2009 where DOM Level 2 Events is the current spec and events don't bubble up to the window.

I'll send a PR to skip the test in IE 8 since the tested behavior actually shouldn't occur in that browser.

scottgonzalez added a commit to scottgonzalez/jquery-ui that referenced this pull request Oct 26, 2015
@scottgonzalez
Draggable: Skip window bubbling test in IE 8
693f680 
IE 8 implements DOM Level 2 Events which only has events propagate
up to the document, not the window.

Ref #10818
Ref jquerygh-1621
@scottgonzalez scottgonzalez mentioned this pull request Oct 26, 2015
Closed
scottgonzalez added a commit that referenced this pull request Oct 27, 2015
@scottgonzalez
Draggable: Skip window bubbling test in IE 8
33398fa 
IE 8 implements DOM Level 2 Events which only has events propagate
up to the document, not the window.

Ref #10818
Ref gh-1621
Closes gh-1627
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@hmethvin @jquerybot @jzaefferer @scottgonzalez