Fix not splitting elements and unnecessary overflowing in close fit case#125
Merged
adamwulf merged 1 commit intoadamwulf:masterfrom Aug 22, 2013
Merged
Fix not splitting elements and unnecessary overflowing in close fit case#125adamwulf merged 1 commit intoadamwulf:masterfrom
adamwulf merged 1 commit intoadamwulf:masterfrom
Conversation
The wrong condition causes that in closefit case regular elements (WITHOUT dontsplit class) are being put entirely into the current column without even trying to split them. Because of that, it often overflows, even if there's no reason for that, because we can actually split it very accurately.
Contributor
Author
|
Basically there are 3 cases. If we are processing image or element with the dontsplit class and it's close fit, we squeeze it to the current column. If it's not close fit, we put it in the next column. Otherwise, if we are processing regular text element without dontsplit class, regardless closeness of the fit, we try to split it for the exact height. This is how I understand it from the comments and it seems logical. There's just this one little mistake. I already reported it 8 months ago: #76 |
adamwulf
added a commit
that referenced
this pull request
Aug 22, 2013
Fix not splitting elements and unnecessary overflowing in close fit case
Owner
|
yikes, really not sure why it took me so long to get on this. thanks for filing + for the pull request. it's in master now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The wrong condition causes that in closefit case regular elements (WITHOUT dontsplit class) are being put entirely into the current column without even trying to split them. Because of that, it often overflows, even if there's no reason for that, because we can actually split it very accurately.