Skip to content

Minor improvements #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kinow merged 5 commits into from
Feb 17, 2019
Merged

Minor improvements #17

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e9f1cd8
Remove unused import
kinow Feb 16, 2019
6ab7e0c
Remove test code that used deprecated constructors for Numbers (calli…
kinow Feb 16, 2019
8e50846
Fix generics warning when creating a list
kinow Feb 16, 2019
6a706a6
Make ESCAPE_CHAR as static as in other classes (QuotedPrintableCodec,…
kinow Feb 16, 2019
680a648
Fix checkstyle issues
kinow Feb 16, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix generics warning when creating a list
  • Loading branch information
@kinow
kinow committed Feb 16, 2019
commit 8e5084631769bd7973110cf2e40dd374baaeec19
2 changes: 1 addition & 1 deletion src/main/java/org/apache/commons/codec/language/DaitchMokotoffSoundex.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -501,7 +501,7 @@ private String[] soundex(final String source, final boolean branching) {
}

// use an EMPTY_LIST to avoid false positive warnings wrt potential null pointer access
final List<Branch> nextBranches = branching ? new ArrayList<>() : Collections.EMPTY_LIST;
final List<Branch> nextBranches = branching ? new ArrayList<Branch>() : Collections.<Branch>emptyList();

for (final Rule rule : rules) {
if (rule.matches(inputContext)) {
Expand Down