Fix outdated comments about FileReader#13
Closed
marcprux wants to merge 1 commit into
Closed
Conversation
The comments mention that the constructor that takes a File or Path internally creates a FileReader with the JVM's default CharSet. This is not the case: it instead creates an InputStreamReader with the specified charset. I've removed the incorrect comments.
Member
|
The patch did not apply cleanly to our Git master. I made the changes nonetheless. Please verify and close. |
Member
Author
|
LGTM! |
DarrenJAN
added a commit
to DarrenJAN/commons-csv
that referenced
this pull request
Dec 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The comments mention that the constructor that takes a File or Path internally creates a FileReader with the JVM's default CharSet. This is not the case: it instead creates an InputStreamReader with the specified charset. I've removed the incorrect comments.