Skip to content

Fix outdated comments about FileReader #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
marcprux wants to merge 1 commit into from
Closed

Fix outdated comments about FileReader #13

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 1 addition & 11 deletions src/main/java/org/apache/commons/csv/CSVParser.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,11 +138,6 @@ public final class CSVParser implements Iterable<CSVRecord>, Closeable {
/**
* Creates a parser for the given {@link File}.
*
* <p><strong>Note:</strong> This method internally creates a FileReader using
* {@link java.io.FileReader#FileReader(java.io.File)} which in turn relies on the default encoding of the JVM that
* is executing the code. If this is insufficient create a URL to the file and use
* {@link #parse(URL, Charset, CSVFormat)}</p>
*
* @param file
* a CSV file. Must not be null.
* @param charset
Expand Down Expand Up @@ -192,12 +187,7 @@ public static CSVParser parse(final InputStream inputStream, final Charset chars
}

/**
* Creates a parser for the given {@link File}.
*
* <p><strong>Note:</strong> This method internally creates a FileReader using
* {@link java.io.FileReader#FileReader(java.io.File)} which in turn relies on the default encoding of the JVM that
* is executing the code. If this is insufficient create a URL to the file and use
* {@link #parse(URL, Charset, CSVFormat)}</p>
* Creates a parser for the given {@link Path}.
*
* @param path
* a CSV file. Must not be null.
Expand Down