Skip to content

FIX #io-697#336

Closed
richarda23 wants to merge 8 commits into
apache:masterfrom
richarda23:filefilter-test-comments
Closed

FIX #io-697#336
richarda23 wants to merge 8 commits into
apache:masterfrom
richarda23:filefilter-test-comments

Conversation

@richarda23

Copy link
Copy Markdown
Contributor

this PR clarifies Javadoc of 2 methods to match the behaviour displayed by the code. Previously the Javadoc was ambiguous as to the expected behaviour when size was a value > 0 but less than the length of the InputStream.

@kinow kinow left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kinow kinow left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, was going to merge it when I realized the Javadocs did not build after this change. Could you take a look at the GitHub actions log output (you can click on the checks in this pr, follow the links to find the logs). It should point what failed to build. It appears to be due to "malformed HTML". Thanks!

@kinow

kinow commented Mar 25, 2022

Copy link
Copy Markdown
Member

Almost there! I'm re-running a failed macos job in GH actions, to see if it was some glitch in the macos build or if there's still something missing here. 👍

@richarda23

Copy link
Copy Markdown
Contributor Author

ok, sorry, made some heavy weather on this. all ok now

@kinow kinow closed this in d8b4807 Mar 25, 2022
@kinow

kinow commented Mar 25, 2022

Copy link
Copy Markdown
Member

Thanks a lot for the initial PR and for the patience to work through the javadoc issues @richarda23 . I rebased the branch, squashed the commits down to a single commit, updated the commit message to include the JIRA issue, added the entry in changes.xml and merged locally. Finally, pushed to master 👍 JIRA Issue updated as well.

Merged, fixed. Thanks @richarda23 !!

@richarda23 richarda23 deleted the filefilter-test-comments branch March 29, 2022 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants