Skip to content

FIX #io-697 #336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
richarda23 wants to merge 8 commits into from
Closed

FIX #io-697 #336

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
0896cfb
(doc) - fix misleading comments
otter606 Mar 14, 2022
7f74870
fix #io-697
otter606 Mar 24, 2022
18179ea
Merge branch 'master' into filefilter-test-comments
otter606 Mar 24, 2022
fe04c59
fix docs for overloaded method
otter606 Mar 24, 2022
19b2b55
improve parameter docs
otter606 Mar 24, 2022
c2b40f2
escape <
Mar 25, 2022
73567a9
Remove accidentally committed file
Mar 25, 2022
fc84bff
fix javadoc
Mar 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
(doc) - fix misleading comments
  • Loading branch information
@otter606
otter606 committed Mar 14, 2022
commit 0896cfbe30f41bb00a4a484495a1923b230b356a
16 changes: 8 additions & 8 deletions src/test/java/org/apache/commons/io/filefilter/FileFilterTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1208,21 +1208,21 @@ public void testPrefixCaseInsensitive() {
IOFileFilter filter = new PrefixFileFilter(new String[] {"foo", "bar"}, IOCase.INSENSITIVE);
assertFiltering(filter, new File("foo.test1"), true);
assertFiltering(filter, new File("bar.test1"), true);
assertFiltering(filter, new File("FOO.test1"), true); // case-sensitive
assertFiltering(filter, new File("BAR.test1"), true); // case-sensitive
assertFiltering(filter, new File("FOO.test1"), true); // case-insensitive
assertFiltering(filter, new File("BAR.test1"), true); // case-insensitive

filter = new PrefixFileFilter("bar", IOCase.INSENSITIVE);
assertFiltering(filter, new File("foo.test2"), false);
assertFiltering(filter, new File("bar.test2"), true);
assertFiltering(filter, new File("FOO.test2"), false); // case-sensitive
assertFiltering(filter, new File("BAR.test2"), true); // case-sensitive
assertFiltering(filter, new File("FOO.test2"), false); // case-insensitive
assertFiltering(filter, new File("BAR.test2"), true); // case-insensitive

final List<String> prefixes = Arrays.asList("foo", "bar");
filter = new PrefixFileFilter(prefixes, IOCase.INSENSITIVE);
assertFiltering(filter, new File("foo.test3"), true);
assertFiltering(filter, new File("bar.test3"), true);
assertFiltering(filter, new File("FOO.test3"), true); // case-sensitive
assertFiltering(filter, new File("BAR.test3"), true); // case-sensitive
assertFiltering(filter, new File("FOO.test3"), true); // case-insensitive
assertFiltering(filter, new File("BAR.test3"), true); // case-insensitive

assertThrows(IllegalArgumentException.class, () -> new PrefixFileFilter((String) null, IOCase.INSENSITIVE));
assertThrows(IllegalArgumentException.class, () -> new PrefixFileFilter((String[]) null, IOCase.INSENSITIVE));
Expand All @@ -1231,8 +1231,8 @@ public void testPrefixCaseInsensitive() {
filter = FileFilterUtils.prefixFileFilter("bar", IOCase.INSENSITIVE);
assertFiltering(filter, new File("foo.test2"), false);
assertFiltering(filter, new File("bar.test2"), true);
assertFiltering(filter, new File("FOO.test2"), false); // case-sensitive
assertFiltering(filter, new File("BAR.test2"), true); // case-sensitive
assertFiltering(filter, new File("FOO.test2"), false); // case-insensitive
assertFiltering(filter, new File("BAR.test2"), true); // case-insensitive

assertThrows(IllegalArgumentException.class, () -> FileFilterUtils.prefixFileFilter(null, IOCase.INSENSITIVE));
}
Expand Down