Skip to content

[IO-414] Don't write a BOM on every (or any) line#492

Merged
garydgregory merged 6 commits into
apache:masterfrom
elharo:IO-414
Oct 7, 2023
Merged

[IO-414] Don't write a BOM on every (or any) line#492
garydgregory merged 6 commits into
apache:masterfrom
elharo:IO-414

Conversation

@elharo

@elharo elharo commented Oct 7, 2023

Copy link
Copy Markdown
Contributor

Per JDK docs, "When decoding, the UTF-16 charset interprets the byte-order mark at the beginning of the input stream to indicate the byte-order of the stream but defaults to big-endian if there is no byte-order mark; when encoding, it uses big-endian byte order and writes a big-endian byte-order mark."

@codecov-commenter

codecov-commenter commented Oct 7, 2023

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.07%. Comparing base (877b9e3) to head (25c4e69).
⚠️ Report is 1745 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #492      +/-   ##
============================================
+ Coverage     84.97%   85.07%   +0.10%     
- Complexity     3372     3373       +1     
============================================
  Files           227      227              
  Lines          8080     8082       +2     
  Branches        953      954       +1     
============================================
+ Hits           6866     6876      +10     
+ Misses          960      951       -9     
- Partials        254      255       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@garydgregory garydgregory merged commit 469ef76 into apache:master Oct 7, 2023
@garydgregory garydgregory changed the title [IO-414] don't write a BOM on every (or any) line [IO-414] Don't write a BOM on every (or any) line Oct 7, 2023
asfgit pushed a commit that referenced this pull request Oct 7, 2023
asfgit pushed a commit that referenced this pull request Oct 7, 2023
asfgit pushed a commit that referenced this pull request Oct 7, 2023
elharo added a commit to elharo/commons-io that referenced this pull request Oct 8, 2023
elharo added a commit to elharo/commons-io that referenced this pull request Oct 8, 2023
garydgregory pushed a commit that referenced this pull request Oct 8, 2023
* Revert "Revert "[IO-414] don't write a BOM on every (or any) line (#492)""

This reverts commit 43594ce.

* Revert "Revert "[IO-414] Don't write a BOM on every (or any) line #492""

This reverts commit 914ca79.

* revert the revert

* detab

* detab
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants