[IO-414] Don't write a BOM on every (or any) line#493
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #493 +/- ##
=========================================
Coverage 84.88% 84.88%
- Complexity 3381 3382 +1
=========================================
Files 228 228
Lines 8116 8117 +1
Branches 960 961 +1
=========================================
+ Hits 6889 6890 +1
Misses 964 964
Partials 263 263 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Hi @elharo |
|
mvn test doesn't catch checkstyle errors. I have to look for those specifically. On the previous iteration, the CI passed on my PR. The code was somehow modified after I submitted it. |
No you don't, as noted above, run |
|
Side note: In general, don't edit As an alternative, we could use Log4j's change log mechanism which avoids any and all conflicts. |
Something very weird happened with the previous iteration of this PR. This PR should work.