Skip to content

[IO-807] Copy symlinks, not the files the symlinks point to#558

Merged
garydgregory merged 5 commits into
apache:masterfrom
elharo:link
Jan 14, 2024
Merged

[IO-807] Copy symlinks, not the files the symlinks point to#558
garydgregory merged 5 commits into
apache:masterfrom
elharo:link

Conversation

@elharo

@elharo elharo commented Jan 14, 2024

Copy link
Copy Markdown
Contributor

At initial commit this test fails.

@garydgregory

@codecov-commenter

codecov-commenter commented Jan 14, 2024

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 85.99%. Comparing base (ff6c3ec) to head (a8e2693).
Report is 985 commits behind head on master.

Files with missing lines Patch % Lines
src/main/java/org/apache/commons/io/FileUtils.java 75.00% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #558      +/-   ##
============================================
- Coverage     86.00%   85.99%   -0.01%     
- Complexity     3495     3498       +3     
============================================
  Files           231      231              
  Lines          8250     8256       +6     
  Branches        963      965       +2     
============================================
+ Hits           7095     7100       +5     
  Misses          865      865              
- Partials        290      291       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@elharo elharo changed the title update test to reflect desired behavior of copying broken symlinks Copy symlinks, not the files the symlinks point to Jan 14, 2024
@elharo elharo changed the title Copy symlinks, not the files the symlinks point to [IO-807] Copy symlinks, not the files the symlinks point to Jan 14, 2024
@elharo elharo marked this pull request as ready for review January 14, 2024 15:04
@garydgregory garydgregory merged commit ec4144b into apache:master Jan 14, 2024
asfgit pushed a commit that referenced this pull request Jan 14, 2024
- Use diamond notation
- Reuse PathUtils.EMPTY_COPY_OPTIONS
- Refactor calls to toPath()
@elharo elharo deleted the link branch January 14, 2024 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants