Skip to content

[IO-807] Copy symlinks, not the files the symlinks point to #558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
garydgregory merged 5 commits into from
Jan 14, 2024
Merged

[IO-807] Copy symlinks, not the files the symlinks point to #558

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
cff7177
update test to reflect desired behavior of copying broken symlinks
elharo Jan 14, 2024
9089174
[IO-807] copy symbolic links as links
elharo Jan 14, 2024
8da94f6
pmd
elharo Jan 14, 2024
57e1336
typo
elharo Jan 14, 2024
a8e2693
add test for unbroken link
elharo Jan 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
update test to reflect desired behavior of copying broken symlinks
  • Loading branch information
@elharo
elharo committed Jan 14, 2024
commit cff71772686033d97acd9fa2ecb4a92aa2d8acc0
11 changes: 5 additions & 6 deletions src/test/java/org/apache/commons/io/FileUtilsTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -783,12 +783,11 @@ public void testCopyDirectory_brokenSymLink() throws IOException {

// Now copy sourceDirectory, including the broken link, to another directory
final File destination = new File(tempDirFile, "destination");
final FileNotFoundException thrown = assertThrows(
FileNotFoundException.class,
() -> FileUtils.copyDirectory(sourceDirectory, destination),
"ignored broken link"
);
assertTrue(thrown.getMessage().contains("linkfile' does not exist"));
FileUtils.copyDirectory(sourceDirectory, destination);
assertTrue(destination.exists());
File copiedBrokenSymlink = new File(destination, "linkfile");
assertTrue(Files.isSymbolicLink(copiedBrokenSymlink.toPath()));
assertFalse(Files.exists(copiedBrokenSymlink.toPath()));
}

@Test
Expand Down