[TEXT-209]Fixed LookupTranslator returns count of codepoints consumed#324
Closed
fourAjeff wants to merge 1 commit intoapache:masterfrom
Closed
[TEXT-209]Fixed LookupTranslator returns count of codepoints consumed#324fourAjeff wants to merge 1 commit intoapache:masterfrom
fourAjeff wants to merge 1 commit intoapache:masterfrom
Conversation
kinow
approved these changes
May 19, 2022
Member
kinow
left a comment
There was a problem hiding this comment.
Thank you for the contribution and for adding a unit test too.
Member
|
Merged. Thanks!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
This a quick bugfix on the LookupTranslator. The bug returns count of chars consumed, not of codepoints consumed.
A full description of the problem is found in the ticket: https://issues.apache.org/jira/browse/TEXT-209