Skip to content

[TEXT-209]Fixed LookupTranslator returns count of codepoints consumed #324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
fourAjeff wants to merge 1 commit into from
Closed

[TEXT-209]Fixed LookupTranslator returns count of codepoints consumed #324

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/java/org/apache/commons/text/translate/LookupTranslator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ public int translate(final CharSequence input, final int index, final Writer wri

if (result != null) {
writer.write(result);
return i;
return Character.codePointCount(subSeq, 0, subSeq.length());
}
}
}
Expand Down
13 changes: 13 additions & 0 deletions src/test/java/org/apache/commons/text/translate/LookupTranslatorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,4 +61,17 @@ public void testFailsToCreateLookupTranslatorThrowsInvalidParameterException() {
assertThatExceptionOfType(InvalidParameterException.class).isThrownBy(() -> new LookupTranslator(null));
}

@Test
public void testTranslateSupplementaryCharacter() {
/* Key: string with Mathematical double-struck capital A (U+1D538) */
String symbol = new StringBuilder().appendCodePoint(0x1D538).toString();
/* Map U+1D538 to "A" */
Map<CharSequence, CharSequence> map = new HashMap<>();
map.put(symbol, "A");
LookupTranslator translator = new LookupTranslator(map);
String translated = translator.translate(symbol + "=A");
/* we should get "A=A". */
assertThat(translated).as("Incorrect value").isEqualTo("A=A");
}

}