Fix application of addMobileStyle in beforeShow() #11
Closed
mykwillis wants to merge 1 commit intoarschmitz:masterfrom
Closed
Fix application of addMobileStyle in beforeShow() #11mykwillis wants to merge 1 commit intoarschmitz:masterfrom
mykwillis wants to merge 1 commit intoarschmitz:masterfrom
Conversation
Owner
|
thank you this looks good ill land it shortly |
Owner
|
@mykwillis just went to land this and realized that this was already fixed when i just landed #18 so im going to close this as fixed by #18 thank you for the PR though! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I believe this was a typo in the last commit that was fixing the application of styles. Without this change, the browser chokes on the modified line because ".data("mobileDate") is null.