Custom callbacks allowed

[indrimuska]

Perform customization of callbacks onSelect / onChangeMonthYear / beforeShow without loosing mobile style.

Demo: http://jsbin.com/indrimuska/42/edit.

[arschmitz]

you are assigning a global variable in an if statement here i think what you want is to just do if( that.options[ "_" + val ]) { then below do that.options[ "_" + val ].apply( null, args );

[indrimuska]

Yes, it's the same.
There are many ways to do that:

1. Assign in the if-statement (my way):
   if ( callback = that.options[ '_'+val ] ) { callback.apply( null, args ); }
2. Without assignment (your way):
   if ( that.options[ '_'+val ] ) { that.options[ '_'+val ].apply( null, args ); }
3. Assignment before the if-statement:
   var callback = that.options[ '_'+val ]; if ( callback ) { callback.apply( null, args ); }

My goal is to rename user callback, i.e. onSelect, into _onSelect, and then recall the callback after to add the mobile style to the datepicker. In this way, ui-date triggers the overridden onSelect which takes care to execute addMobileStyle(); and _onSelect if set.

[arschmitz]

@indrimuska yes what your trying to do is correct but you are creating a global variable because you are not using var and we cannot create global variables. I would like the non assignment way because assignment offers no benefit here

[indrimuska]

Thank you @arschmitz, I've followed your advice.

[arschmitz]

@indrimuska can you make a seperate pr for fixing the height of the days?

[indrimuska]

Ok, I'll do it asap.