Skip to content

Dev #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Dev #58

wants to merge 2 commits into from

Conversation

XhmikosR
Copy link
Contributor

@XhmikosR XhmikosR commented Feb 11, 2021

So, this is not perfect in the sense that the default Windows shell is Powershell, but it should still catch some issues.

I can move the first patch to a separate PR, but this reminds me that the source-map version used here is not the same as in clean-css.

So, regarding Windows:

  1. FOO=BAR command does not work. Better use process.env and node foo since Windows don't support shebangs
  2. rm and cp don't exist on Windows. Better use native Node fs API

Refs #52

@jakubpawlowicz note that you can push to my branch so that you get this working before merging :)

@XhmikosR XhmikosR closed this Oct 3, 2021
@XhmikosR XhmikosR deleted the dev branch October 3, 2021 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant