Fix URL canonicalization to handle non-UTF-8 encoded characters. Fixes #6#28
Closed
tfmorris wants to merge 3 commits into
Closed
Fix URL canonicalization to handle non-UTF-8 encoded characters. Fixes #6#28tfmorris wants to merge 3 commits into
tfmorris wants to merge 3 commits into
Conversation
|
Thanks, @tfmorris! We'll have a look. |
|
Just for reference - the discussion in CC's Google group: https://groups.google.com/g/common-crawl/c/ek5bme_RIuM Opened PR upstream: iipc#102 |
|
Closing this in favor of the upstream PR iipc#102 which is integrated
The fix was already in use for the January 2025 crawl. Verification of the solution:
See also: https://commoncrawl.org/errata/surt-urls-do-not-properly-encode-non-utf-8-percent-encoded-characters Thanks again, @tfmorris! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6
Fixes issue with percent signs (%) getting double escaped for hex encoded characters which use an encoding other than UTF-8.
There is a separate issue with the hex characters being lower case instead of upper case as recommended by both Google canonicalization guidelines (V2) and RFC 3986, which this patch does NOT address.