-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Specify language when adding image descriptions #1501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
This should be a very quick thing to add. If it provides so much value to our users I am sure we can find an eager contributor who can help us implement it. Both the parts should be easy enough ie specifying the language and allowing users to add several descriptions. |
Hi @maskaravivek I want to take this up |
Sure, go ahead! Can you share mocks for the screen once you start working on it? |
Thanks @maskaravivek, Will update you with the mocks as soon as i am done :-) |
@VojtechDostal Can the title also be multiple languages? If that's the case then the language selection drop-down can be common for both title and description. By default, the drop-down should be showing the phone's language selected by default. Moreover, a little plus button below the title and description can let the user add it in a different language. |
Sure the title is usually typed in a specific language, but it can also be something like "DFHTTRHTHT.jpg", you can name your pictures like that and there is nothing to stop you (at worst someone will rename it). You cannot provide more than one language variant of the title (currently) because the title is filename at the same time. This may change in future with Structured Commons. But currently there is no way to mark language of title of files in Wikimedia Commons. |
Great thanks for the clarification @VojtechDostal! Here's the scope of this task.
|
One small modification. I just realized it should rather be like this: {{en|1=PLACEHOLDER TEXT OF DESCRIPTION}}{{cs|1=Another description but now in Czech}} Language template with the "1=" construct is the correct format used by Commons Uploader. |
Thanks @VojtechDostal! Have updated the scope based on your comment. :) |
@maskaravivek @VojtechDostal Can I conclude, that the requirement is to
|
Yes @ashishkumar468 . If the app for any reason fails to load the default language of the system, you can instead insert {{unknown language|1=PLACEHOLDER}}. |
@VojtechDostal @maskaravivek Cool, will update once done |
@VojtechDostal @maskaravivek Could you guys point me to some api for image upload, as in from where I could see what all languages are supported and what exactly would be the key used for a language while uplaod |
Hi @ashishkumar0207 the list of supported languages for these language templates is here: https://commons.wikimedia.org/wiki/Commons:Language_templates |
* wip * Changes for adding descriptions in multipe languages[issue #1501] * Added callback for the adapter * Codacy suggested changes * Sort the languages in the spinner in alphabetical order * scroll view nested scrolling enabled false * Nested scrolling enabled false [Allow rv to expand] * rebased to master, resolved conflicts * replaced setCompoundDrawables with setCompoundDrawablesWithIntrinsicBounds [the former dint used to work on all devices] * replaced setCompoundDrawables with setCompoundDrawablesWithIntrinsicBounds [the former dint used to work on all devices]
* wip * Changes for adding descriptions in multipe languages[issue commons-app#1501] * Added callback for the adapter * Codacy suggested changes * Sort the languages in the spinner in alphabetical order * scroll view nested scrolling enabled false * Nested scrolling enabled false [Allow rv to expand] * rebased to master, resolved conflicts * replaced setCompoundDrawables with setCompoundDrawablesWithIntrinsicBounds [the former dint used to work on all devices] * replaced setCompoundDrawables with setCompoundDrawablesWithIntrinsicBounds [the former dint used to work on all devices]
@VojtechDostal @maskaravivek The issue is open. Is there still a bug that needs to be fixed or a feature that needs to be added? |
This is a feature request :-) |
Yes. I meant, since the issue has not been closed, is there any feature (or part of it) that is left to be implemented? |
This is implemented in master and should be released in 2.9. :) Thanks all! |
Descriptions on Wikimedia Commons are usually multilingual. Specifying the language of description is considered important and is basically mandatory in the official Commons uploader. However our app does not currently enable specification of language.
There could be a roll-out menu like I show below:
The technical implementation into resulting Commons pages is then rather simple. The descriptions are encased in language templates like this one (for English description): {{en|PLACEHOLDER TEXT OF DESCRIPTION}}.
If we want, we could even allow users to add several descriptions, in any number of languages. The descriptions are then just added one after another like this: {{en|PLACEHOLDER TEXT OF DESCRIPTION}}{{cs|Another description but now in Czech}}.
The text was updated successfully, but these errors were encountered: