Feature/localised image descriptions #1634
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1634 +/- ##
=========================================
- Coverage 3.63% 3.57% -0.07%
=========================================
Files 182 186 +4
Lines 9158 9327 +169
Branches 796 811 +15
=========================================
Hits 333 333
- Misses 8803 8972 +169
Partials 22 22
Continue to review full report at Codecov.
|
|
The feature works well for me and I was able to upload an image with descriptions in multiple languages. The descriptions show up well on Commons. https://commons.wikimedia.org/wiki/File:Gandhi_ji_painting_at_Aga_khan_palace.jpg @ashishkumar468 Can you sort the languages drop-down list alphabetically. Right now it's a bit difficult to browse through so many language options. |
|
@maskaravivek Thanks for the review, have updated the same |
|
Hi guys, i believe not just my account, my device is blocked from uploading images [I guess because of multiple test images upload]. Does any one know how to get it fixed ? |
|
@ashishkumar468 I'm not sure about the block. but will ping @whym and @nicolas-raoul who might hopefully be able to help. In the future, for uploading test images please use the betaDebug build variant as far as possible. All uploads to the prodDebug build variant will go to the real Commons, and indeed the community may not be too happy with it. |
|
Sorry about the block! But before doing this, maybe we should use your case to test the block detection code in the app? :-) |
|
Thanks guys, will do the same |
|
Just a gentle reminder, the PR is ready for review |
|
Sorry for the wait for review, @ashishkumar468 , we are having a bit of a backlog with work at the moment. :/ Will get to it ASAP. |
|
Works with no problem for me @ashishkumar468 , thanks for this great feature. Just a few points:
For this PR, first bullet and fixing conflicts is important. Others can wait. |
|
Hi @neslihanturan, Thanks for the feedback, Could you elaborate the first bullet, As far as i understand, you mean to say that instead of two recycler views which is there currently, you want only one recycler view which would hold both the language field and the description field? |
|
It is very normal you didn't get what I meant:) I was trying to say, you can use a listview (or recycler) with "search filter". So that when I want to use Turkish language, I can just type Turkish to search bar, instead of scrolling all the languages and trying to find Turkish. When user selects laguages filter could be beneficial. |
|
@neslihanturan Ohh yes got it it now, Thanks for the clarification, will work on the same and update |
@ashishkumar468 Can you please resolve the merge conflicts so that this PR can be merged. |
|
@maskaravivek @neslihanturan Have resolved the conflicts, (@neslihanturan Will take a while to add the filter you suggested, will update you once done). Also I noticed that startForeground has not been handled properly for Oreo devices. |
|
The travis build failed with some exception in SettingsActivityTest, does not seems any way related to my commit, what am i supposed to do ? |
|
@ashishkumar468 Have you rebased your branch with latest master? The build for master is successful. |
|
@maskaravivek I have already merged with master, you can see the logs from git |
8559aab to
d61a21f
Compare
|
@maskaravivek @neslihanturan Did the required changes. Please verify |
…ounds [the former dint used to work on all devices]
…Bounds [the former dint used to work on all devices]
|
Works well for me. Merging. Thanks @ashishkumar468 |
* wip * Changes for adding descriptions in multipe languages[issue commons-app#1501] * Added callback for the adapter * Codacy suggested changes * Sort the languages in the spinner in alphabetical order * scroll view nested scrolling enabled false * Nested scrolling enabled false [Allow rv to expand] * rebased to master, resolved conflicts * replaced setCompoundDrawables with setCompoundDrawablesWithIntrinsicBounds [the former dint used to work on all devices] * replaced setCompoundDrawables with setCompoundDrawablesWithIntrinsicBounds [the former dint used to work on all devices]
Specify language when adding image descriptions
Specify language when adding image descriptions #1501
Description :
Converted the descriptions edit text to a recycler veiw with and option to add description in various languages
Tests performed :
Open the app, click on the camera/gallery icon to upload an image, the next screen which would usually show an option to add a single description, would now let you add description in multiple languages (the default (first) one would be the device locale). Submit the request. After upload success, open the image description, I could now see description in my device current locale.
Tested on {27l & name of Moto x, with {build variant, ProdDebug}.
Screenshots showing what changed (optional)