Prompted to log in even though I am already logged in

[nicolas-raoul]

Steps to reproduce:

• Install the app
• Skip login
• Go to Nearby and try to upload something
• You are told to login, so enter name/password
• You are redirected to "My uploads"
• Go to Nearby and try to upload something
• You are told to login

Commons app version:
That's master with #1800 merged in.
Yes, I should try with a clean master too.

[ujjwalagrawal17]

I start working on it.

[nicolas-raoul]

Have you managed to reproduce the problem?

[ujjwalagrawal17]

Umm, I couldn't reproduce it in skip login branch. I Will check master branch for this issue.

[nicolas-raoul]

Trying to reproduce this, I got this strange error at step 5, probably unrelated:

08-08 17:02:20.501   786  1129 W GnssLocationProvider: Invalid size of GpsSvStatus found: 0.             
08-08 17:02:20.536 22592 22592 D NearbyActivity: Map fragment already exists, just update the map and list          
08-08 17:02:20.944   209   209 I rmt_storage: rmt_storage_connect_cb: clnt_h=0x19 conn_h=0xb6a9a0f0                                                                                                 
08-08 17:02:20.944   209   209 I rmt_storage: rmt_storage_rw_iovec_cb: /boot/modem_fs1: clnt_h=0x1: req_h=0x1d msg_id=3: R/W request received
08-08 17:02:20.944   209   209 I rmt_storage: wakelock acquired: 1, error no: 2                                                                                                                                                                              
08-08 17:02:20.944   209   453 I rmt_storage: rmt_storage_client_thread: /boot/modem_fs1: clnt_h=0x1 Unblock worker thread (th_id: -1230505696)                                                             
08-08 17:02:20.994 22592 23046 I mbgl    : {DefaultFileSour}[Database]: statement aborts at 42: [UPDATE tiles SET accessed       = ?1 WHERE url_template = ?2   AND pixel_ratio  = ?3   AND x            = ?4   AND y            = ?5   AND z            = ?6
 ] attempt to write a readon (Code 1032)                                                                                                                                                                                  
08-08 17:02:21.048   209   453 I rmt_storage: rmt_storage_client_thread: /boot/modem_fs1: clnt_h=0x1: req_h=0x1d msg_id=3: Bytes written = 1572864                                                              
08-08 17:02:21.048   209   453 I rmt_storage: rmt_storage_client_thread: /boot/modem_fs1: clnt_h=0x1: req_h=0x1d msg_id=3: Send response: res=0 err=0
08-08 17:02:21.048   209   453 I rmt_storage: rmt_storage_client_thread: /boot/modem_fs1: clnt_h=0x1 About to block rmt_storage client thread (th_id: -1230505696) wakelock released: 1, error no: 0
08-08 17:02:21.048   209   453 I rmt_storage:                                                                                                                                                                                                                08-08 17:02:21.048   209   209 I rmt_storage: rmt_storage_disconnect_cb: clnt_h=0x0x19 conn_h=0x0xb6a9a0f0
08-08 17:02:21.064 22592 23046 F libc    : /usr/local/google/buildbot/src/android/ndk-r15-release/external/libcxx/../../external/libcxxabi/src/abort_message.cpp:74: void abort_message(const char *, ...): assertion "terminating with uncaught exception of
 type mapbox::sqlite::Exception: attempt to write a readonly database" failed                                                                                                                
08-08 17:02:21.068 22592 23046 F libc    : Fatal signal 6 (SIGABRT), code -6 in tid 23046 (DefaultFileSour)                                                                                                                                                  
08-08 17:02:21.069 22592 22592 W OpenGLRenderer: Points are too far apart 4.000000                                      
08-08 17:02:21.073   158   158 W         : debuggerd: handling request: pid=22592 uid=10209 gid=10209 tid=23046                                                                                                                    
08-08 17:02:21.325 29652 29652 F DEBUG   : *** *** *** *** *** *** *** *** *** *** *** *** *** *** *** ***                                                                                                                                              
08-08 17:02:21.325 29652 29652 F DEBUG   : LineageOS Version: '14.1-20170718-NIGHTLY-hammerhead'                                                  
08-08 17:02:21.326 29652 29652 F DEBUG   : Build fingerprint: 'google/hammerhead/hammerhead:6.0.1/M4B30Z/3437181:user/release-keys'                        
08-08 17:02:21.326 29652 29652 F DEBUG   : Revision: '11'                                                                                                  
08-08 17:02:21.326 29652 29652 F DEBUG   : ABI: 'arm'                                                                                                                                    
08-08 17:02:21.326 29652 29652 F DEBUG   : pid: 22592, tid: 23046, name: DefaultFileSour  >>> fr.free.nrw.commons <<<
08-08 17:02:21.326 29652 29652 F DEBUG   : signal 6 (SIGABRT), code -6 (SI_TKILL), fault addr --------                                          
08-08 17:02:21.335 29652 29652 F DEBUG   : Abort message: '/usr/local/google/buildbot/src/android/ndk-r15-release/external/libcxx/../../external/libcxxabi/src/abort_message.cpp:74: void abort_message(const char *, ...): assertion "terminating with uncau
ght exception of type mapbox::sqlite::Exception: attempt to write a readonly database" failed'                                                                                                             
08-08 17:02:21.335 29652 29652 F DEBUG   :     r0 00000000  r1 00005a06  r2 00000006  r3 00000008
08-08 17:02:21.335 29652 29652 F DEBUG   :     r4 9683c978  r5 00000006  r6 9683c920  r7 0000010c                                                                      
08-08 17:02:21.335 29652 29652 F DEBUG   :     r8 96d677a5  r9 94a3d540  sl 9683c710  fp 94a3d58c                                                                                                                                                            
08-08 17:02:21.335 29652 29652 F DEBUG   :     ip 00000002  sp 9683bf38  lr b4775107  pc b4777970  cpsr 600f0010                                                                                                                                             
08-08 17:02:21.393 29652 29652 F DEBUG   :                                                                                                                             
08-08 17:02:21.393 29652 29652 F DEBUG   : backtrace:                                                                                                                                                                                                        
08-08 17:02:21.398 29652 29652 F DEBUG   :     #00 pc 0004a970  /system/lib/libc.so (tgkill+12)                                                                                                                                                              
08-08 17:02:21.398 29652 29652 F DEBUG   :     #01 pc 00048103  /system/lib/libc.so (pthread_kill+34)                                                                                  
08-08 17:02:21.398 29652 29652 F DEBUG   :     #02 pc 0001d715  /system/lib/libc.so (raise+10)                                                                    
08-08 17:02:21.398 29652 29652 F DEBUG   :     #03 pc 00019261  /system/lib/libc.so (__libc_android_abort+34)                                                       
08-08 17:02:21.398 29652 29652 F DEBUG   :     #04 pc 00017128  /system/lib/libc.so (abort+4)                  
08-08 17:02:21.398 29652 29652 F DEBUG   :     #05 pc 0001b713  /system/lib/libc.so (__libc_fatal+22)                                                          
08-08 17:02:21.398 29652 29652 F DEBUG   :     #06 pc 0001945b  /system/lib/libc.so (__assert2+18)             
08-08 17:02:21.398 29652 29652 F DEBUG   :     #07 pc 00326873  /data/app/fr.free.nrw.commons-1/lib/arm/libmapbox-gl.so

[nicolas-raoul]

I could not reproduce the issue on current master + the PR, so I merge.