Night mode: Category pages

[millbittencourt]

Summary:

When clicking on a category in night mode, the app does not show the "Parent Categories", there's a blank space instead.

Steps to reproduce:

How can we reproduce the issue?
Settings > Night Mode;
Explore > Click any image > Click on a random categorie > Parent Categories

What did you expect the app to do, and what did you see instead?
The names of the parent categories should be shown.

Device and Android version:

Found on Xiaomi A1, Android 8.1.0

Commons app version:
2.8.5

Screen-shots:

Would you like to work on the issue?

Yess.

[vanshikaarora]

Hey!!
Have you made any changes to your code. My app crashes while trying to open this activity. It gives null pointer exception.

java.lang.NullPointerException: Attempt to invoke virtual method 'android.support.v4.app.FragmentActivity android.support.v4.app.Fragment.getActivity()' on a null object reference
at fr.free.nrw.commons.media.MediaDetailPagerFragment$MediaDetailAdapter.getItem(MediaDetailPagerFragment.java:401)

[domdomegg]

@vanshikaarora I think that's unrelated. I fixed that in 46db38b

[domdomegg]

Just checked, this also happens in subcategories. So basically any categories page

[vanshikaarora]

Ok @domdomegg I'll check that out

[domdomegg]

@vanshikaarora are you working on this? Just want it to be clear for other developers looking at issues.

[Divyanshu2132]

I am working on this issue

[domdomegg]

Okay. I'm going to do the tabs separately in #2186, so please don't change them if possible (to avoid merge conflicts)

[Divyanshu2132]

Sure
I'll talk to you before changing or creating pull request

[Divyanshu2132]

@domdomegg I have created a pull request look into the files changed to avoid merge conflicts