Fix #2090 and #2088: Night mode issues with search and categories #2213
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2213 +/- ##
=========================================
+ Coverage 5.87% 5.88% +<.01%
=========================================
Files 231 231
Lines 11587 11572 -15
Branches 1078 1077 -1
=========================================
Hits 681 681
+ Misses 10849 10834 -15
Partials 57 57
Continue to review full report at Codecov.
|
maskaravivek
approved these changes
Jan 1, 2019
This was referenced Jan 1, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #2090 and fixes #2088
What changes did you make and why?
RecentSearchesFragment.javaandSearchActivity.java. Wasn't necessary, and made it harder to track what was going on. Appearance related stuff should be kept in xml as much as possible.item_recent_searches.xmlto remove its white backgrounditem_recent_searches_dark_theme.xmlWas trying to fix #2095, ended up with something completely different. Fixes #2088 by accident, as
SearchCategoriesRenderer.javaalso usesR.layout.item_recent_searcheswhich was the root cause for both issues. Sorry for taking over these issues.Note that this does not deal with the tabs issue, that is separate in #2186.
Tests performed
Tested
2.9.0-debug-master~493fa6b72onGalaxy Nexus (emulator)with API level28Tested
2.9.0-debug-master~493fa6b72onGalaxy Nexus (emulator)with API level25See screenshots for results below
Search - no recent searches
Search - recent searches
Search - media results
Search - no media results
Search - category results
Search - no category results
Category - media
Category - subcategories
Category - no subcategories
Category - parent categories